Correct the MMIO mapping size calculation, which
previously relied on an invalid start/end subtraction.

This change corrects a functional bug and cleans up the driver without
altering its behavior.

Fixes: 111e9bf6a5ac ("mailbox: add PolarFire SoC mailbox driver")
Signed-off-by: Jamie Gibbons <[email protected]>
---
 drivers/mailbox/mpfs-mbox.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mailbox/mpfs-mbox.c b/drivers/mailbox/mpfs-mbox.c
index 55238847ecd..4a9465c7a72 100644
--- a/drivers/mailbox/mpfs-mbox.c
+++ b/drivers/mailbox/mpfs-mbox.c
@@ -145,7 +145,7 @@ static int mpfs_mbox_probe(struct udevice *dev)
                return ret;
        };
 
-       mbox->ctrl_base = devm_ioremap(dev, regs.start, regs.start - regs.end);
+       mbox->ctrl_base = devm_ioremap(dev, res.start, resource_size(&res));
 
        ret = ofnode_read_resource(node, 2, &regs);
        if (ret) {
@@ -153,7 +153,7 @@ static int mpfs_mbox_probe(struct udevice *dev)
                return ret;
        };
 
-       mbox->mbox_base = devm_ioremap(dev, regs.start, regs.start - regs.end);
+       mbox->mbox_base = devm_ioremap(dev, res.start, resource_size(&res));
 
        mbox->dev = dev;
        dev_set_priv(dev, mbox);
-- 
2.43.0

Reply via email to