Re: [PATCH 3/6] sysinfo: tq_eeprom: new driver

[Feilke, Alexander]

On 08/05/2026 19:58, Simon Glass wrote:
> Hi Nora,
>
> On 2026-05-08T08:48:28, Feilke, Alexander
> <alexander.fei...@ew.tq-group.com> wrote:
>> diff --git a/drivers/sysinfo/tq_eeprom.c b/drivers/sysinfo/tq_eeprom.c
>> @@ -0,0 +1,223 @@
>> +     for (i = 0; i < sizeof(data->id); i++) {
>> +             if (!(isprint(data->id[i]) && isascii(data->id[i])))
>> +                     break;
>> +     }
> isprint() already implies the ASCII printable range - you can drop the
> isascii() check.
isprint() alone does not eliminate 0xff, which is the default value for an 
erased eeprom.