Hi Federico,

On 23/05/2026 15:04, Federico Amedeo Izzo via B4 Relay wrote:
> This series enables UFS support on SC7280 devices with UFS3.1.
> SC7280 devices with UFS2.2 were already working.
> 
> The root cause was ABL leaving vcc-supply regulator disabled on UFS3.1
> devices, and enabled on UFS2.2 devices that worked fine without
> regulator support.

Thanks a lot for working on this and finding the bug in the regulator
driver!

> 
> Signed-off-by: Federico Amedeo Izzo <[email protected]>

Reviewed-by: Casey Connolly <[email protected]>

> ---
> Changes in v4:
> - Improve regulator mode fix: apply current mode during enable
> - Remove regulator mode code from qcom-ufs driver
> - Link to v3: 
> https://patch.msgid.link/[email protected]
> 
> Changes in v3:
> - Fix bug causing HPM mode not being applied. Removed LPM/HPM hack
> - Read regulator mode from dts property instead of hardcoding it
> - Link to v2: 
> https://patch.msgid.link/[email protected]
> 
> Changes in v2:
> - Add vccq2-supply for UFS2.2 devices without internal eLDO regulator
> - Fix wrong topic
> - Link to v1: 
> https://patch.msgid.link/[email protected]
> 
> To: Sumit Garg <[email protected]>
> To: [email protected]
> To: [email protected]
> Cc: Jaehoon Chung <[email protected]>
> Cc: Peng Fan <[email protected]>
> Cc: Casey Connolly <[email protected]>
> Cc: Neil Armstrong <[email protected]>
> Cc: Tom Rini <[email protected]>
> Cc: Luca Weiss <[email protected]>
> Cc: Aswin Murugan <[email protected]>
> Cc: Federico Amedeo Izzo <[email protected]>
> Cc: Bhupesh Sharma <[email protected]>
> Cc: Neha Malcom Francis <[email protected]>
> Cc: Julien Stephan <[email protected]>
> Cc: Marek Vasut <[email protected]>
> 
> ---
> Federico Amedeo Izzo (2):
>       regulator: qcom-rpmh-regulator: fix regulator mode mismatch
>       ufs: qcom: add ufs host regulator support
> 
>  drivers/power/regulator/qcom-rpmh-regulator.c | 106 
> ++++++++++++++------------
>  drivers/ufs/ufs-qcom.c                        |  25 ++++++
>  drivers/ufs/ufs-qcom.h                        |   4 +
>  3 files changed, 85 insertions(+), 50 deletions(-)
> ---
> base-commit: 744cf5d4e398c5f657e5c3eeb44d00fa5175dc85
> change-id: 20260521-qcom-ufs-regulator-support-466ea6ad202a
> 
> Best regards,
> --  
> Federico Amedeo Izzo <[email protected]>
> 
> 

-- 
// Casey (she/her)

Reply via email to