hi Daniel,
On 6/10/26 10:39 AM, Daniel Palmer wrote:
Hi Quentin, Tom
On Mon, 8 Jun 2026 at 23:22, Quentin Schulz <[email protected]> wrote:
Also, lib/Makefile has
obj-$(CONFIG_SPL_YMODEM_SUPPORT) += crc16-ccitt.o
which is.... odd? Shouldn't this handle the case of "missing" SPL_CRC16
dependency?
I didn't see this. So it seems like for now just adding
CONFIG_YMODEM_SUPPORT, making that select CONFIG_CRC16 and the
Makefile tweak would be enough for now.
Would that be acceptable for now? It seems like the xyzmodem thing
needs a bit of refactoring etc. I actually have an almost entirely
rewritten version of it somewhere that I wrote because of the issues
in the current version. I'd prefer to fix the build issue for now and
refactor + replace most of the code when I have time to do it
properly.
I'm fine fixing what needs to be fixed now and improvements later on.
Note that we generally do not like complete rewrites in one patch but
rather small incremental changes (which may end up in the same result,
but is "more reviewable"). We don't have a maintainer for that feature,
though Tom is the "catch-all" maintainer, so maybe you can convince him
a full rewrite is ok. In any case, I'm sure we would really appreciate
tests (I don't think we have any from the cursory check I just made) so
make sure to include some (especially for the issues you encountered so
we don't regress!).
Cheers,
Quentin
