On 6/12/26 11:51 AM, [email protected] wrote:

Hello Kuwano-san,

+CC GigaDevice

diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c
index c0fa98424aa..d3a24b51daf 100644
--- a/drivers/mtd/spi/spi-nor-ids.c
+++ b/drivers/mtd/spi/spi-nor-ids.c
@@ -117,6 +117,11 @@ const struct flash_info spi_nor_ids[] = {
                         SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
                         SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
         },
+       {
+               INFO("gd25lq16", 0xc86015, 0, 64 * 1024, 32,
+                       SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
+                       SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)

I could find a datasheet of GD25LQ16E that mentions the same ID (C8 60 15).
https://www.mouser.com/datasheet/2/870/gd25lq16e_datasheet_v1_2_20210108-2399660.pdf?srsltid=AfmBOopEr50lYWZuINw4geNljXqWZxHqvrYc-_HyJi7ISbOc_9RRaiC1

This chip has 4 BP bits (BP3..BP0) + TB (BP4).
The u-boot driver doesn't support 4-bit BP yet so locking feature shouldn't
work as expected.

That is a good point.

I had a brief look at it, and it looks like it would be possible to pick a couple of kernel patches to support the various SR topologies, I created a test branch [1] with those patches. Do you think this is a workable approach ?

[1] https://source.denx.de/u-boot/custodians/u-boot-usb/-/commits/spi-nor-4bit-sr

--
Best regards,
Marek Vasut

Reply via email to