On 6/15/26 9:56 AM, Rasmus Villemoes wrote:
Hello Rasmus,
+*.dtb.clean.dts
+*.dtb.diff
+*.dtb.full.dts
Would it make sense to simply change this to *.dtb.* ? Or do you think
that is too much ?
I think I'm leaning on the explicit mention of each suffix. Had there
already been a *.dtb.* pattern, I would probably not have noticed and
thus not been prompted to amend the 'make clean' rule, so I think it's
better that some potential future .dtb.foo artifact does show up in 'git
status' as an untracked file. But this is certainly not a strong
opinion, and I'd be fine either way.
I would be fine with .dts.foo showing up, but .dtb.foo are most likely
build artifacts ?
Yes, but my point was that if we add a blanket *.dtb.* pattern to
.gitignore, the fact that some future .dtb.foo does _not_ show up in 'git
status' will make it less likely for the developer who adds .dtb.foo, or
someone else shortly afterwards, to note that it wasn't added to the
clean rule, as I'm sure we agree that it should be.
Ahhh, I understand now, thank you for clarifying.
Hence I think the
patterns should be added one by one to .gitignore in tandem with their
addition to the clean rule. But it's still not a strong opinion, so if
you or Tom or someone else think *.dtb.* in .gitignore is the way to go,
I won't object.
I retract my concern.
Reviewed-by: Marek Vasut <[email protected]>
Thank you.
