On Monday 06 August 2012 18:45:58 Joe Hershberger wrote: > On Mon, Aug 6, 2012 at 2:02 PM, Benoît Thébaudeau wrote: > > There's a lot of stuff in U-Boot relying on ethaddr being set, e.g. the > > bdinfo command, or the linklocal command because of seed_mac. If ethaddr > > is not set, bdinfo will report exactly that, but linklocal will wait > > indefinitely without displaying anything. > > This sounds like a problem to be fixed one way or another.
there was a patch floating around for setting up ethaddr env var automatically in the net core during init if it wasn't already set > > Hence, shouldn't the users of ethaddr rather use dev->enetaddr, or is > > ethaddr really supposed to be required (bug or feature)? > > Because of the logic that prevents dev->enetaddr set from hardware to > override ethaddr (since ethaddr should always be the source of the MAC > in all but exceptional cases), it seems to me that using ethaddr is > correct. Perhaps in the case of bdinfo, it could explicitly say that > ethaddr is not set, and if dev->enetaddr is in use, it could also > print that. no, nothing outside of the net layer should ever touch dev->enetaddr. this is clearly documented in doc/README.enetaddr. -mike
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
