Hi Tien Fong, On 16/4/2026 11:30 am, Chee, Tien Fong wrote: > Hi Dinesh, > > > On 11/3/2026 1:00 pm, [email protected] wrote: >> From: Dinesh Maniyam <[email protected]> > > > The subject could say Agilex 5 explicitly (spl_agilex5) so it is obvious > it is not all SoCFPGA. > > >> >> Program SECURE_TRANS_REG when CONFIG_SPL_MMC is enabled >> to allow ATF loaded from MMC to access the secure DDR region. >> >> Signed-off-by: Dinesh Maniyam <[email protected]> >> --- >> arch/arm/mach-socfpga/spl_agilex5.c | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/arch/arm/mach-socfpga/spl_agilex5.c >> b/arch/arm/mach-socfpga/spl_agilex5.c >> index 1be347360f5..d0c2af795de 100644 >> --- a/arch/arm/mach-socfpga/spl_agilex5.c >> +++ b/arch/arm/mach-socfpga/spl_agilex5.c >> @@ -110,6 +110,14 @@ void board_init_f(ulong dummy) >> } >> } >> >> + /* >> + * Set secure transaction for mmc, so ATF image from mmc can be loaded > > > capitalize MMC, minor grammar (“so an ATF image loaded from MMC can …”). > > >> + * to secure region reserved for ATF in DDR. >> + */ >> + if (IS_ENABLED(CONFIG_SPL_MMC)) >> + writel(SECURE_TRANS_SET, SECURE_TRANS_REG); >> + } > > > That extra } would be a syntax error > > > Best regards, > > Tien Fong >
Thanks for the review. I'll update the subject to arm: socfpga: spl_agilex5: ..., fix the comment wording (MMC / grammar), and remove the extra '}' that would cause a syntax error. Will send v2. Best regards, Dinesh
