On July 21, 2026 thus sayeth Andrew Davis: > On 7/21/26 10:30 AM, Bryan Brattlof wrote: > > From: Anshul Dalal <[email protected]> > > > > When using ofnode_null() the node offset passed to the FDT API will be > > -1 which is invalid and breaks probe. Switch to dev_ofnode() > > > > Signed-off-by: Anshul Dalal <[email protected]> > > Signed-off-by: Bryan Brattlof <[email protected]> > > --- > > drivers/firmware/scmi/scmi_agent-uclass.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/firmware/scmi/scmi_agent-uclass.c > > b/drivers/firmware/scmi/scmi_agent-uclass.c > > index cd458a7f4588..65c1ddad2b57 100644 > > --- a/drivers/firmware/scmi/scmi_agent-uclass.c > > +++ b/drivers/firmware/scmi/scmi_agent-uclass.c > > @@ -437,7 +437,7 @@ static int scmi_bind_protocols(struct udevice *dev) > > /* initialize the device from device tree */ > > drv = DM_DRIVER_GET(scmi_base_drv); > > name = "scmi-base.0"; > > - ret = device_bind(dev, drv, name, NULL, ofnode_null(), &proto); > > + ret = device_bind(dev, drv, name, NULL, dev_ofnode(dev), &proto); > > If we always used to pass null here, and that breaks probe as the commit > message states, how did this ever work for anyone else?
I though it was odd a well but other platforms don't seem to have any issues right now which made be second guess. But yeah I can update the commit body. ~Bryan
