On Mon, Jul 27, 2026 at 02:59:13PM +0800, Eric Chung wrote: > Read the product name from the environment instead of EEPROM, > as the EEPROM may not be programmed and the environment always > contains this information.
Please explain why the environment "always contains this information". This sounds strange since the environment variable is placed on MMC, and there should be no "product_name" environment variable in the environment partition if U-Boot is flashed to a completely new and empty MMC. The EEPROM should be the most robost way to distinguish board types. If you do have devices with unprogrammed EEPROMs, please provide a guide to program it correctly. Furthremore, this doesn't seem to fit the subject of the series, "spacemit mmc driver", since I don't think these changes are required for MMC to work. So I think this patch should be split out even if you do want to change the board detection logic. > Signed-off-by: Eric Chung <[email protected]> Best regards, Yao Zi
