One thing neither patch touches, which I am happy to send separately if
you want it:

        board_local_name = calloc(1, MAX_NAME_LENGTH);
        if (!board_info)
                return NULL;

The calloc() result is never checked -- the test is on board_info -- so
an allocation failure leaves a NULL destination for the first
strcat()/strlcat().  And that early return leaks board_local_name,
where every other exit goes through the error: label and frees it.
Both look like the same typo.

Yes. Please send a patch for it with also 2/2 from this series.

Thanks,
Michal

--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP/Versal ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal/Versal NET SoCs
TF-A maintainer - Xilinx ZynqMP/Versal/Versal NET SoCs

Reply via email to