Discard checkboard() implementation in Rockchip mach: DISPLAY_CPUINFO prints SoC info; therefore, having DISPLAY_BOARDINFO(_LATE) to print it too, as an alternative, seems redundant and misleading. Moreover, it seems preferable not to implement checkboard() at mach level, leaving the overriding available for board level implementation if needed. BTW this is the approach taken by most of the other mach.
Side effect: Rockchip board configurations related to PX30 RK3308 or any RK35xx having DISPLAY_BOARDINFO(_LATE) option selected but not DISPLAY_CPUINFO one, must select the latter too to keep printing SoC info. Signed-off-by: Massimo Pegorer <[email protected]> --- arch/arm/mach-rockchip/cpu-info.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/arch/arm/mach-rockchip/cpu-info.c b/arch/arm/mach-rockchip/cpu-info.c index 79ea3e17185..616cd45c6bf 100644 --- a/arch/arm/mach-rockchip/cpu-info.c +++ b/arch/arm/mach-rockchip/cpu-info.c @@ -15,15 +15,6 @@ __weak int rockchip_print_soc(void) return -ENOTSUPP; } -int checkboard(void) -{ - /* Print SOC only if not already printed by CPUINFO */ - if (!IS_ENABLED(CONFIG_DISPLAY_CPUINFO)) - rockchip_print_soc(); - - return 0; -} - __weak enum rockchip_rst_cause rockchip_get_reset_cause(void) { return RST_CAUSE_UNAVAILABLE; -- 2.34.1
