Hi Vincent,
Please don't take this in a bad way, but please be the first reviewer of
your own code.
This is just a mechanical paste of v3 over v2 which shows the raw delta,
the majority of which is just gratuitous formatting change. It is very
difficult to review.
On Wed, Sep 16, 2026 at 11:15:45PM +0200, Vincent Jardin wrote:
> Fix the commit
> 035d68fc36b5 ("lx2160: add lx2160_serdes split and management")
> which is in next.
I'd suggest picking a different word than 'fix', which means something
was broken.
Best is to have one single logical change per patch, and to make it
obvious to the reviewer through the commit message that the change is
justified and correct.
> It leads to the following commands which are more explicit:
>
> lx2160_sd1 100g4x25g
> CHANGES the SerDes 1 Ethernet mode: it re-groups SD1's
> eight lanes and re-points its protocol converters.
>
> lx2160_serdes status [1|2|3]
> only READS, any of the three SerDes, unchanged syntax.
>
> In order to prepare the next commits, this mode should be:
> 100g4x25g (1x 100G + 4x 25G),
> instead of "split", same for its hwconfig key:
>
> setenv hwconfig serdes1:100g4x25g && saveenv
>
> The follow-up patches will add more SerDes 1 modes under the lx2160_sd1.
>
> The SerDes 3 and LX2160A-only branches use IS_ENABLED() instead of
> preprocessor conditionals, and the header no longer wraps its
> declarations in CONFIG_ARCH_LX2160A: the definitions stay guarded in
> serdes_split.c.
>
> Signed-off-by: Vincent Jardin <[email protected]>
