Hi Torsten,

On 2026-09-25T10:54:32, Torsten Duwe <[email protected]> wrote:

> The next three patches are simply the RP1 components for their
> respective subsystems; and then I pick up Volodymyr's idea to use
> board_late_init to stitch RP1 and PCIe together. In the long run, it
> might turn out necessary to enhance U-Boot's probing architecture to
> handle alternating cycles of device tree and PCI probed devices in
> general.

Thanks for putting this together! I'm really looking forward to having
U-Boot fully functional on this board. When I run it on rpi5 I see:

...
PCIe BRCM: link down
PCIe BRCM: link up, 5.0 Gbps x4 (!SSC)
Net:   No ethernet found.

PCIe BRCM: link down
starting USB...
USB XHCI 1.10
USB XHCI 1.10
USB DWC2
Resetting EP 0...
Resetting EP 3...
WARN endpoint is halted
Resetting EP 2...
WARN endpoint is halted
Resetting EP 3...
WARN endpoint is halted
Resetting EP 0...
Resetting EP 3...
WARN endpoint is halted
Resetting EP 2...
WARN endpoint is halted
Resetting EP 3...
WARN endpoint is halted
Resetting EP 0...
Resetting EP 3...
WARN endpoint is halted
Resetting EP 2...
WARN endpoint is halted
Resetting EP 3...
WARN endpoint is halted
Resetting EP 0...
Resetting EP 3...
WARN endpoint is halted
Resetting EP 2...
WARN endpoint is halted
Resetting EP 3...
WARN endpoint is halted
Resetting EP 0...
Resetting EP 3...
WARN endpoint is halted
Resetting EP 2...
WARN endpoint is halted
Resetting EP 3...
WARN endpoint is halted
 ** fs_devread read error - block
Bus usb@200000: 2 USB Device(s) found
Bus usb@300000: 2 USB Device(s) found
Bus usb@480000: 1 USB Device(s) found
       scanning usb for storage devices... 2 Storage Device(s) found
Hit any key to stop autoboot: 0
U-Boot> nvme scan
U-Boot> nvme detail
U-Boot> usb stor
  Device 0: Vendor: USB      Rev: 1100 Prod: Flash Disk
            Type: Removable Hard Disk
            Capacity: 30720.0 MB = 30.0 GB (62914560 x 512)
  Device 1: Vendor:  USB Rev: 1.00 Prod:  SanDisk 3.2Gen1
            Type: Removable Hard Disk
            Capacity: 29358.0 MB = 28.6 GB (60125184 x 512)
U-Boot>

So it seems that my S2Pi + NVMw is not detected? Which board are you using here?

Also, I'm not sure if you see the warnings/resetting messages above?

> mfd: add support for RPi5 RP1 chip MFD

The patch order feels backwards - the MFD is the parent that carries
the PCI IDs and instantiates the clk and gpio children, yet it lands
as patch 6, after its children in patches 4 and 5. Please reorder so
the MFD comes first, followed by clk and gpio, then the
board_late_init glue if needed. That also makes each intermediate
state easier to bisect.

Also it would be good to mention in doc/board/broadcom/raspberrypi.rst
mentions that NVMe, RP1 GPIO and USB now work on RPi5, or what is
still missing (network boot).

Regards,
Simon

Reply via email to