Hi Jérémie, On 2026-09-11T16:35:05, Jérémie Dautheribes (Schneider Electric) <[email protected]> wrote: > binman: add nxp_imxcst base etype for i.MX CST signing > > Add a common etype which provides the shared functionality for signing > i.MX images with the NXP Code Signing Tool (CST). This includes the SRK > table property handling, the CST bintool registration, and helpers for > writing the input data and configuration files and for running cst. > > The nxp_imx8mcst etype and the upcoming nxp_imx93cst etype will be > converted to use this common base in the following commits. > > No functional changes. > > Signed-off-by: Jérémie Dautheribes (Schneider Electric) > <[email protected]> > > tools/binman/etype/nxp_imxcst.py | 121 +++++++++++++++++++++++++++++++++++++++ > 1 file changed, 121 insertions(+)
> diff --git a/tools/binman/etype/nxp_imxcst.py > b/tools/binman/etype/nxp_imxcst.py > @@ -0,0 +1,121 @@ > + def ReadNode(self): > + super().ReadNode() > + self.srk_table = os.getenv( > + 'SRK_TABLE', > + fdt_util.GetString(self._node, 'nxp,srk-table', > 'SRK_1_2_3_4_table.bin'), > + ) Thanks for splitting out the common class, this looks good. This line is 85 columns; the original in nxp_imx8mcst.py wraps at 80, so please keep that. Regards, Simon
