Hi Jérémie, On 2026-09-11T16:35:05, Jérémie Dautheribes (Schneider Electric) <[email protected]> wrote: > binman: nxp_imx8mcst: use the nxp_imxcst base etype > > Use the freshly introduced new nxp_imxcst base etype and remove > dupplicated code.
Typo: 'duplicated'. Also 'freshly introduced new' is redundant; 'Use the new nxp_imxcst base etype' is enough. The refactor looks good: the dropped imports (Entry, elf, OrderedDict) are all unused, and SetImagePos(), AddBintools() and the CST invocation move across unchanged. The existing testNxpImx8mCST* tests all still pass. > This should not have any functional impact. > > Signed-off-by: Jérémie Dautheribes (Schneider Electric) > <[email protected]> > > tools/binman/etype/nxp_imx8mcst.py | 60 +++++++------------------------------- > 1 file changed, 10 insertions(+), 50 deletions(-) Reviewed-by: Simon Glass <[email protected]>
