Hi Suraj, On 2026-09-29T11:02:52, Suraj Kakade <[email protected]> wrote:
> Patch 1 fixes a build failure where a long $(srctree) makes the > HOSTCC/CPP command line for cmd_dtc/cmd_dtco exceed the shell's > argument limit, by writing dtc_cpp_flags to a response file and > passing @file instead. This relies on the $(file ...) function, > which requires GNU Make >= 4.0. > > Patch 2 raises the enforced minimum GNU Make version to 4.0, adding > an explicit "GNU Make >= 4.0 is required" check to the top-level > Makefile and dropping the now-dead GNU Make 3.x compatibility > branches. Please can you swap the order of these two patches? Patch 1 depends on Make 4.0 before patch 2 enforces it. On Make 3.x the unknown $(file ...) function expands to nothing, so the response file is never written. HOSTCC then gets an @ argument pointing at a missing file, which gcc treats as a literal input name. Anyone building with an older Make, or bisecting onto patch 1, gets a confusing dtc/cpp failure instead of a clear message. If the version check comes first, patch 1 can just say that it is now safe to use $(file ...) Regards, Simon
