Hi Heinrich, On 2026-10-12T14:00:39, Heinrich Schuchardt <[email protected]> wrote: > test: test_erofs: adjust expected ls output > > With the addition of the date field the space between columns in the ls > output has been reduced. Reflect this in the expected lines of the erofs > test.
erofs never prints a date, so the date field is not what changes this output. Patch 2 changes the separator after the size and '<SYM>' from three spaces to one for every filesystem that uses fs_ls_generic(), whether or not FS_CAP_DATE is set. Please can you reword this to say that? > diff --git a/test/py/tests/test_fs/test_erofs.py > b/test/py/tests/test_fs/test_erofs.py > @@ -65,8 +65,8 @@ def erofs_ls_at_root(ubman): > - expected_lines = ['./', '../', '4096 f4096', '7812 f7812', 'subdir/', > - '<SYM> symdir', '<SYM> symfile', '4 file(s), 3 > dir(s)'] > + expected_lines = ['./', '../', '4096 f4096', '7812 f7812', 'subdir/', > + '<SYM> symdir', '<SYM> symfile', '4 file(s), 3 dir(s)'] squashfs needs the same fix. sqfsls also uses fs_ls_generic() and CONFIG_CMD_SQUASHFS is enabled in sandbox_defconfig. Can you check that test_sqfs_ls() passes with this series applied? > > Signed-off-by: Heinrich Schuchardt <[email protected]> > > test/py/tests/test_fs/test_erofs.py | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) Regards, Simon
