Hi Heinrich, On 2026-10-12T14:00:39, Heinrich Schuchardt <[email protected]> wrote:
> * Let the ls command print the change date for FAT and ext4 files. Patch 2 also cuts the gap between the size column and the name for every filesystem that uses fs_ls_generic(). That includes squashfs and erofs, where no date is printed. If that stays, please can you mention it in the cover letter, since scripts or tests that match on ls output will notice. > * Adjust tests. Please can you fold each test change into the patch that causes it. As it stands, patches 2 and 3 break test_fs, test_env and test_erofs until patches 7–9 land, which makes the series hard to bisect. The new patterns in patches 7 and 8 also match the old output, so those could simply go at the start. > * Correctly update the change date when writing ext4 files. The tests only loosen the regexes so that the date is optional. Nothing checks that the right date is printed, or that ext4write now stores the RTC time. Sandbox has an emulated RTC whose time can be set, so a test could write a file with fatwrite and ext4write and then check the date that ls shows. That would cover patches 2, 3 and 5 together. Regards, Simon
