Hi Dinesh,

On Wed,  9 Sep 2026 13:40:46 +0800, [email protected] wrote:

From: Dinesh Maniyam <[email protected]>

Add device tree, U-Boot dtsi and a defconfig for the Agilex5 E-Series
013B SoCDK (DK-A5E013BM16AEA). The board uses a 64 MB QSPI flash with
a different layout than the base SoCDK, so it needs its own DT and
defconfig rather than a DT overlay on the existing target.

Keep Linux-facing MMC essentials in the .dts and Cadence PHY timing in
the U-Boot dtsi, matching the base Agilex5 SoCDK split. Advertise
sd-uhs-sdr50 with 1.8 V signalling (sd_io_1v8_reg); leave SDR104 and
DDR50 to a separate UHS PHY timing series. Alias ethernet0 to the
enabled gmac2 port and use snps,dwxgmac-mdio for its MDIO child.

Defconfig disables PHY_MARVELL and enables PHY_MICREL/KSZ90X1 vs base SoCDK without commit-message rationale

Please one sentence tying Micrel KSZ90x1 to DK-A5E013BM16AEA

diff --git a/arch/arm/dts/socfpga_agilex5_socdk_013b.dts 
b/arch/arm/dts/socfpga_agilex5_socdk_013b.dts
@@ -0,0 +83,9 @@
+};
+
+&mmc {
+       bus-width = <4>;
+       cap-sd-highspeed;
+       disable-wp;
+};
+
+&osc1 {

Commit message places Linux-facing MMC essentials in the .dts, but &mmc only sets bus-width/cap-sd-highspeed/disable-wp.

Please add status = "okay" under &mmc in the .dts (or clarify Linux enablement is out of scope)

[...]

@@ -0,0 +99,5 @@
+               #address-cells = <1>;
+               #size-cells = <1>;
+               compatible = "jedec,spi-nor";
+               reg = <0>;
+               spi-max-frequency = <100000000>;

Sibling Agilex5 boards use mt25qu02g; 013B uses generic jedec,spi-nor with a 64MB map

Please prefer specific compatible when the part is known

[...]

diff --git a/board/intel/agilex5-socdk/MAINTAINERS 
b/board/intel/agilex5-socdk/MAINTAINERS
@@ -8,3 +8,6 @@ S:      Maintained
 F:     include/configs/socfpga_agilex5_socdk.h
 F:     configs/socfpga_agilex5_defconfig
+F:     configs/socfpga_agilex5_013b_defconfig
 F:     configs/socfpga_agilex5_nand2_defconfig
+F:     arch/arm/dts/socfpga_agilex5_socdk_013b.dts
+F:     arch/arm/dts/socfpga_agilex5_socdk_013b-u-boot.dtsi

New F: lines use spaces after F: while existing entries use a tab

Please match surrounding F:\tpath style


Best regards,
Tien Fong

Reply via email to