Hi Andre, Thanks for having a look. I'll reorder the patches and move the DT bits to dts/upstream for v2, once there's more feedback.
Pablo On Fri, Oct 16, 2026 at 6:28 PM Andre Przywara <[email protected]> wrote: > > Hi Pablo, > > On 10/16/26 11:16, Pablo Mazzini wrote: > > The Allwinner B288 (sun8iw10p1) is a dual Cortex-A7 SoC used in e-book > > readers. This series adds SPL and U-Boot support for it, and one board: > > the PocketBook Verse (PB629). > > > The DT is still under review for Linux. Until it reaches > > dts/upstream, the last patch carries a copy in arch/arm/dts. > > Thanks for sending this, much appreciated. I had a coarse look over > this, and this looks fine on the first glance. > As you said, this is somewhat blocked on the DT merge on the Linux side, > which will probably not happen this year anymore (v7.5-rc1 would be the > earliest). > But meanwhile, in preparation for that, could you please reorder the > patches, so you enable the devices first (clocks, pinctrl, mmc), then > DRAM, then the general support patch, with the defconfig on top. > > For the DT parts: please try to emulate the future situation, so put the > files in the directories where they would end up eventually. You can try > to take the Linux DT binding patch (for clock and reset), and just > change the paths in there to point to the respective dts/upstream > directories. This is what would happen anyway, look for those > cherry-picks and upstream references in the dts/upstream git log. > And the patch(es) wouldn't be taken as such anyway, but they provide a > test base and reference for other people, until the DT lands. > > There is no need to send a new version now, just wait until you receive > some review or other comments. > > Cheers, > Andre > > > > > Tested on a PB629. > > > > Pablo Mazzini (7): > > sunxi: add support for the Allwinner B288 > > sunxi: dram: support the Allwinner B288 > > dt-bindings: clock: add the Allwinner B288 CCU > > clk: sunxi: add the Allwinner B288 gates and resets > > pinctrl: sunxi: add the Allwinner B288 PIO > > mmc: sunxi: B288 mmc0/mmc1 run off PLL_PERIPH0 2x > > sunxi: add the PocketBook Verse > > > > arch/arm/cpu/armv7/sunxi/psci.c | 9 +- > > arch/arm/dts/Makefile | 2 + > > arch/arm/dts/sun8i-b288-pocketbook-verse.dts | 114 ++++++++ > > arch/arm/dts/sun8i-b288.dtsi | 292 +++++++++++++++++++ > > arch/arm/include/asm/arch-sunxi/cpu.h | 1 + > > arch/arm/include/asm/arch-sunxi/cpu_sun4i.h | 16 +- > > arch/arm/mach-sunxi/Kconfig | 14 + > > arch/arm/mach-sunxi/board.c | 4 + > > arch/arm/mach-sunxi/clock_sun6i.c | 1 + > > arch/arm/mach-sunxi/cpu_info.c | 2 + > > arch/arm/mach-sunxi/dram_sunxi_dw.c | 97 +++++- > > board/sunxi/MAINTAINERS | 6 + > > configs/pocketbook_verse_defconfig | 10 + > > drivers/clk/sunxi/Kconfig | 7 + > > drivers/clk/sunxi/Makefile | 1 + > > drivers/clk/sunxi/clk_b288.c | 101 +++++++ > > drivers/clk/sunxi/clk_sunxi.c | 5 + > > drivers/mmc/sunxi_mmc.c | 7 + > > drivers/pinctrl/sunxi/Kconfig | 5 + > > drivers/pinctrl/sunxi/pinctrl-sunxi.c | 22 ++ > > include/dt-bindings/clock/sun8i-b288-ccu.h | 82 ++++++ > > include/dt-bindings/reset/sun8i-b288-ccu.h | 45 +++ > > include/sunxi_gpio.h | 1 + > > 23 files changed, 827 insertions(+), 17 deletions(-) > > create mode 100644 arch/arm/dts/sun8i-b288-pocketbook-verse.dts > > create mode 100644 arch/arm/dts/sun8i-b288.dtsi > > create mode 100644 configs/pocketbook_verse_defconfig > > create mode 100644 drivers/clk/sunxi/clk_b288.c > > create mode 100644 include/dt-bindings/clock/sun8i-b288-ccu.h > > create mode 100644 include/dt-bindings/reset/sun8i-b288-ccu.h > > > > > > base-commit: 65a7532545336e4b73e049a69436e255da7df961 >
