On Mon, Oct 19, 2026 at 06:16:40AM -0700, Simon Glass wrote: > Hi Jiaxun, > > On 2026-10-16T06:54:41, Yao Zi <[email protected]> wrote: > > efi: LoongArch: Implement everything > > > > Implement crt, relocator, linker scripts, and handling of PE relocation > > IMAGE_REL_BASED_LOONGARCH64_MARK_LA. Wire things up in Makefiles and > > Kconfig. The relocator originates gnu-efi project.
... > > diff --git a/arch/loongarch/lib/Makefile b/arch/loongarch/lib/Makefile > > @@ -12,3 +12,15 @@ ifeq ($(CONFIG_$(SPL_)SYSRESET),) > > +extra-$(CONFIG_CMD_BOOTEFI_HELLO_COMPILE) += $(EFI_CRT0) $(EFI_RELOC) > > +extra-$(CONFIG_CMD_BOOTEFI_SELFTEST) += $(EFI_CRT0) $(EFI_RELOC) > > +extra-$(CONFIG_EFI) += $(EFI_CRT0) $(EFI_RELOC) > > CMD_BOOTEFI_HELLO_COMPILE and CMD_BOOTEFI_SELFTEST both select > EFI_LOADER (which selects EFI), so the first two lines look redundant > with the third. The arm and riscv Makefiles rely on CFLAGS alone - was > any of this needed to make the build work? I think lib/Makefile.lib-u-boot now carries default rules for *_efi.so to work out of box, thus this could be removed, thanks. ... > In any case: > > Reviewed-by: Simon Glass <[email protected]> Thanks! All your review comments are reasonable, and I'll apply them in v6. > Regards, > Simon Best regards, Yao Zi
