Hi Markus,

On 2026-10-22T10:15:56, Markus Schneider-Pargmann <[email protected]> wrote:
> dm: core: Add SPL_DM_EVENT
>
> Add an option to allow DM_EVENT in SPL.

Please can you give the reason here: K3 needs to run code from
EVT_DM_POST_INIT_F in SPL, before anything is probed. It would also be
worth noting that this makes device_notify() send probe/remove events
for every device in SPL, not just the post-init event.

> diff --git a/drivers/core/Kconfig b/drivers/core/Kconfig
> @@ -117,6 +117,16 @@ config DM_EVENT
> +config SPL_DM_EVENT
> +     bool
> +     depends on SPL_DM
> +     select SPL_EVENT

SPL_EVENT is inside the 'if EVENT' block in common/Kconfig, so a board
selecting SPL_DM_EVENT without EVENT gets an unmet-dependency warning
and SPL_EVENT is forced on anyway. This is fine for j722s, which
already enables EVENT, but please can you add 'depends on SPL_DM &&
EVENT' so it works for other boards too?

Regards,
Simon

Reply via email to