On Tue, 27 Oct 2026 at 14:55, Marek Vasut <[email protected]> wrote:
>
> On 10/27/26 12:49 PM, Ilias Apalodimas wrote:
>
> Hello Ilias,
>
> > On Mon, 26 Oct 2026 at 22:10, Marek Vasut
> > <[email protected]> wrote:
> >>
> >> If the RPMB is not implemented, then do not warn about it.
> >> This occurs with older OP-TEE OS 3.x :
> >
> > I don't really ming getting this in, but is there no value in
> > TEE_ERROR_NOT_IMPLEMENTED?
> > IOW maybe we should move it to a dev_dbg?
>
> What kind of value ? If TEE_ERROR_NOT_IMPLEMENTED is reported, the
> dev_dbg() in the else branch will trigger, will it not ?

Ah true, I only looked at the patch +- and ignored the context

Reviewed-by: Ilias Apalodimas <[email protected]>

>
> > Cheers
> > /Ilias
> >>
> >> => mmc dev 0
> >> optee optee: Enumeration command 0x2 failed: 0xffff0009
> >> switch to partitions #0, OK
> >> mmc0(part 0) is current device
> >>
> >> Signed-off-by: Marek Vasut <[email protected]>
> >> ---
> >> Cc: Ilias Apalodimas <[email protected]>
> >> Cc: Jan Kiszka <[email protected]>
> >> Cc: Jens Wiklander <[email protected]>
> >> Cc: Tom Rini <[email protected]>
> >> Cc: [email protected]
> >> ---
> >>   drivers/tee/optee/core.c | 3 ++-
> >>   1 file changed, 2 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/tee/optee/core.c b/drivers/tee/optee/core.c
> >> index a47c76811cd..9b18310776d 100644
> >> --- a/drivers/tee/optee/core.c
> >> +++ b/drivers/tee/optee/core.c
> >> @@ -112,7 +112,8 @@ static int __enum_services(struct udevice *dev, struct 
> >> tee_shm *shm, size_t *shm
> >>
> >>          ret = tee_invoke_func(dev, &arg, 1, &param);
> >>          if (ret || (arg.ret && arg.ret != TEE_ERROR_SHORT_BUFFER)) {
> >> -               if (arg.ret != TEE_ERROR_STORAGE_NOT_AVAILABLE)
> >> +               if (arg.ret != TEE_ERROR_STORAGE_NOT_AVAILABLE &&
> >> +                   arg.ret != TEE_ERROR_NOT_IMPLEMENTED)
> >>                          dev_err(dev, "Enumeration command 0x%x failed: 
> >> 0x%x\n", pta_cmd, arg.ret);
> >>                  else
> >>                          dev_dbg(dev, "Enumeration command 0x%x failed due 
> >> to unavailable storage\n", pta_cmd);
> >> --
> >> 2.53.0
> >>
>
>
> --
> Best regards,
> Marek Vasut

Reply via email to