Hi Marek,

On 10/26/26 14:19, Marek Vasut wrote:
>>   static const struct udevice_id usb_onboard_hub_ids[] = {
>>      /* Use generic usbVID,PID dt-bindings (usb-device.yaml) */
>> -    {       .compatible = "usb3431,6241",   /* Corechips SL6341 USB 2.0 */
>> +    {       .compatible = "usb2109,2817",   /* VIA Labs VL817 USB 2.0 */
>> +            .data = (ulong)&vialab_vl817_data,
>> +    }, {
>> +            .compatible = "usb2109,817",    /* VIA Labs VL817 USB 3.0 */
>
> Please keep the list sorted.

I put the new entries first to keep the list in string order: the
existing entries go usb3431, usb424, usb4b4, and "usb2109" sorts before
all of them.

Did you mean sorting by vendor ID as a number instead (0x424, 0x4b4,
0x2109, 0x3431)? That moves the existing entries too, so I would do it
in a separate patch before this one in v2.

Thanks,
Hung-Chun

Reply via email to