Hi Simon, On Sat Oct 31, 2026 at 7:44 PM CET, Simon Glass wrote: > Hi Markus, > > On 2026-10-30T12:27:40+11:00, Markus Schneider-Pargmann > <[email protected]> wrote: >> dm: core: Add SPL_DM_EVENT >> >> Add an option to allow DM_EVENT in SPL. > > Please can you say why this is needed, i.e. that the K3 SoCs want a > spy on EVT_DM_POST_INIT_F in SPL, so they can unlock CTRL_MMR after > TIFS is ready but before any device is probed. It is also worth a > sentence that CONFIG_IS_ENABLED(DM_EVENT) is currently always false in > SPL, so with this option dm_init_and_scan() and device_notify() start > sending events there too. > >> diff --git a/drivers/core/Kconfig b/drivers/core/Kconfig >> @@ -117,6 +117,16 @@ config DM_EVENT >> +config SPL_DM_EVENT >> + bool >> + depends on SPL_DM >> + select SPL_EVENT > > SPL_EVENT is inside 'if EVENT' in common/Kconfig, so it depends on > EVENT. That is fine on K3, since ARCH_K3 selects both, but another > board selecting SPL_DM_EVENT without EVENT would get an > unmet-dependency warning. DM_EVENT selects EVENT, so I suggest adding > 'select EVENT' here too.
Thanks for your review, good points, I will fix both. Best Markus
signature.asc
Description: PGP signature
