In this sense, I'd agree. Descriptive variables can never be a bad thing.
> -----Original Message----- > From: [email protected] [mailto:u2-users- > [email protected]] On Behalf Of Rex Gozar > Sent: Friday, March 04, 2011 11:57 AM > To: U2 Users List > Subject: Re: [U2] Is this worth rewriting? > > George wrote: > > Actually, A:B:C NE '' THEN CUMM(M) = A+B+C > > doesn't slow anything down... > > I think you're talking about execution speed; I was talking about > comprehension. What data type is "A"? Apparently, it can be an empty > string or a number. But more importantly, what does it represent? > Quantity? Dollars? Mileage? Yes, you would have to change the > program to create "self-documenting code" to show the business rules. > > Technically, A:B:C NE "" might be slower than A#"" or B#"" or C#"" > because the system would have to malloc and free string space for the > temporary variable. But that's not my point; it would be faster to > comprehend if I wrote something like: > > IF (SALE.AMT) OR (TAX.AMT) OR (SHIPPING.AMT) THEN > * reinitialize the month with actual amounts > CUMM(MONTH) = SALE.AMT + TAX.AMT + SHIPPING.AMT > END > > (or whatever the OP's code is supposed to represent) > > rex > _______________________________________________ > U2-Users mailing list > [email protected] > http://listserver.u2ug.org/mailman/listinfo/u2-users _______________________________________________ U2-Users mailing list [email protected] http://listserver.u2ug.org/mailman/listinfo/u2-users
