Steve, overall the patch seems ok. But I'm about to add several gconf- keys to notify-osd to tweak some rendering-parameters (title-/body-font, bubble-bg-color, bubble-bg-opacity, bubble-shadow-color, text-fg-color and text-shadow-color). Therefore your patch, being merged into notify- osd trunk, would introduce a dis-balance between notify-osd and "xfce- ified" notify-osd. Thus for the moment I'd rather see your patch being a Xubuntu-specific distro-patch until we can get a 100% feature-parity between GNOME- and XFCE-variants of notify-osd. Also I'd like to then split the gconf- and xconf-related code out into separate .c files for better isolation reasons. Needless to say unit-tests will be needed too as this is an additional requirement for notify-osd development since this (karmic) cycle.
-- Notify-osd & XFCE https://bugs.launchpad.net/bugs/394432 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
