RIght, now that Brian Doe provided a fix for the Vista identification, I
decided to see if my believe about the recovery partition not being
matched and thus being detected as the default of Windows Vista was
correct. Following the insructions from comment #7, I installed hivax,
and checked the BCD record for those partitions.

I am sorry, I should have done that before, as it makes rather clear that the 
recovery partition was indeed not matched, and why:
./probe_bcd /dev/sda1 $bcd
Windows Setup
./probe_bcd /dev/sda2 $bcd
Microsoft Windows Vista

I tested that by adding another elif statement to the 20microsoft file by bdoe:
+       elif grep -qs "W.i.n.d.o.w.s. .S.e.t.u.p" "$2/$boot/$bcd"; then
+               long="Windows Recovery Environment (loader)"
        else
                long="Windows Vista (loader)"
        fi

Running update-grub with the attached file gives me:
Found memtest86+ image: /boot/memtest86+.bin
Found Windows Recovery Environment (loader) on /dev/sda1
Found Windows Vista (loader) on /dev/sda2

which is the correct result.

It might be that other manufacturers give the recovery partition another
BCD record, so I am not claiming this will fix all, but I do think this
is the right fix. Perhaps there is an easier way to record all the
different names that might be used, and possibly it is a good idea to
add hivex to the distribution in the future, to be able to diagnose this
better in the future.

For Lucid it seems that just updating the required matching list seems
like the easiest solution, but that requires all the possible matches to
be identified.

Thanks Brian Doe for inspiring me to finally check this, and thanks TJ
for the hivex package and the shell script. Sorry I did not try it
before.

** Attachment added: "updated /usr/lib/os-probes/mounted/20microsoft file"
   http://launchpadlibrarian.net/51592316/20microsoft

-- 
Grub2 affected when os-prober incorrectly identifies Windows and Recovery 
partitions
https://bugs.launchpad.net/bugs/476625
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to