This patch corrects some errors with AppIndicator support. It is meant to be applied after the first and second patches. The following changes were made:
(1) The function sico_activated() was missing a call to app_indicator_set_menu(), so all menu updates added by the first and second patch had no effect at all. This has been fixed. (2) Some other conditional calls to sico_activated() have been added in places where the mount status of stashes may have changed. (3) All markup is removed from menu labels if cryptkeeper is compiled with AppIndicator support. AppIndicators (currently) don't support markup in menu labels. Some tags, such as <b>, are stripped from the text, while others such as <span> are simply rendered as text (which leads to a problem with the first patch, since unavailable stashes use <span> in their menu entries to set the foreground color to grey). To my knowledge, it has not been decided (yet) whether AppIndicators will support markup in the future, or if all tags will be stripped, or if all tags will be rendered verbatim (see Bug #498725 or Bug #522149 for more information). Removing all markup seemed the most reasonable thing to do under these circumstances. ** Patch added: "0003-Remove-markup-and-fix-menu-updates.patch" https://bugs.launchpad.net/ubuntu/+source/cryptkeeper/+bug/571473/+attachment/1754181/+files/0003-Remove-markup-and-fix-menu-updates.patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/571473 Title: add support for application indicator -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
