Yeah the only concern I have is that when pm-powersave puts the
harddrive to sleep, this might create some kind of incompatibility with
the monitors. ie. After executing the script that sets the drive APM
settings, the monitor will see it as active and will revert the action
taken (in this case powersave)

However, I'm presuming that this wont cause any incompabilities because
of the reason you mentioned, that the harddrive should be considered
idled for the monitor to actually detect it as idled.

I'm going to merge your monitor, however, could you please propose a
branch? It is easier for me to review and merge from a branch. But
please, update the copyright header to list yourself as the author since
you are the one who created. Also, it would be nicer to have the actual
activity check in a separate function from the active function. i.e.:

def active(self):
        if self.is_disk_not_idled():
              return True
        return False

def is_disk_not_idled():
       hdparm etc etc

Thanks again!

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/738764

Title:
  powernap enhancement, DiskMonitor plugin to add monitoring of
  standby/sleeping disks

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to