Hello, the following information should complete this bug as a valid SRU report, to hopefully upload this fix to Lucid.
Solution: Checkbox revision 793 uses wait() instead of the returncode variable when communicating with gconftool to get the preferred browser configuration. This works because subprocess.Popen can potentially return before the process has finished, in which case we won't get the data we need, but using wait() guarantees that the Popened process will have finished by the time we read its output. TEST CASE: 1- Perform a fresh 10.04 installation. 2- apt-get install chromium-browser. 3- Configure Chromium as default browser in System -> Preferred Aplications. 4- Launch system testing. 5- Do a test run (deselect all tests in the selection screen to run this faster). 6- Click on "View report" in the summary screen. Even though Chromium was configured as default browser, Firefox launches and shows the report. Regression potential: Virtually none, the initial code didn't wait for gconftool to finish, which was incorrect behavior, fixed by this. About the only case when a user could be negatively impacted by this is if gconftool hangs; previously, this would result in Firefox launching with the report, whereas now the program will wait until gconftool has finished to launch the report, so a gconftool hang will keep the user waiting for the report. Also, if the user had configured a broken or invalid browser, the old behaviour would have been more desirable, but this is an extremely unlikely scenario. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/562580 Title: checkbox use firefox instead default browser To manage notifications about this bug go to: https://bugs.launchpad.net/checkbox/+bug/562580/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
