Created attachment 658606
Address feedback
(In reply to Patrick McManus [:mcmanus] from comment #40)
> >
> > I'm also seeing warnings about potential deadlock again. Is this just a
> > conservative warning, or something to be addressed?
> >
>
> That's quite real.. I think the reset() logic should take care of it - are
> you confident this is fixed?
Yes. The fact that |Reset| always happens outside of that lock means it
can't cause deadlock.
> (In reply to Adam [:hobophobe] from comment #35)
> >
> > 6. Hover the "Click here to complete the test" and note it is "fail.html"
> >
> > In [6], if we weren't loading an expired entry, we would get the Offline
> > error page. If we were online, it would replace the page with one where the
> > link is to "pass.html"
> >
> > Unless I'm misunderstanding the test, we're still getting expired entries
> > (either without |LOAD_ONLY_FROM_CACHE|, or it's set later).
> >
>
> good test. did you get it resolved so it passes?
That test was to check on Christian's concern in comment 33 and comment
34, that before, when offline, we would still get expired pages, and
that it might not be happening with this change.
The test gives us a page that should immediately expire. Failure means
we did not grab a fresh copy, passing means we did.
My impression is that we're accepting that offline mode may violate
cache expiration, because it can't fetch a fresh copy; that is, that the
failure is the Right Thing. When online, the test passes.
(In reply to Patrick McManus [:mcmanus] from comment #41)
> ::: browser/base/content/test/browser_bug435325.js
> @@ +40,5 @@
> > finish();
> > }
> >
> > registerCleanupFunction(function() {
> > + Services.prefs.setIntPref("network.proxy.type", 2);
>
> you need at least push/pop. Please comment that this is necessary because
> the mochitest proxy runs n localhost and localhost is now reachable even
> when offline.
Added the comments, but wasn't clear if the "push/pop" referred to
something else?
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/367531
Title:
firefox should be smarter about offline access
To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/367531/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
