Comment on attachment 754287
patch
Review of attachment 754287:
-----------------------------------------------------------------
Suite's newsblog.properties needs updating too.
(Seems this patch needs bug 254231 applied first.)
::: mail/locales/en-US/chrome/messenger-newsblog/newsblog.properties
@@ +57,5 @@
> subscribe-confirmFeedDeletion=Are you sure you want to unsubscribe from the
> feed: \n %S?
>
> +subscribe-confirmFeedTitle=Confirm Feed
> +## LOCALIZATION NOTE(subscribe-confirmSubscribe): %S is the number of items
> in a new feed.
> +subscribe-confirmSubscribe=This feed contains %S items. Continue?
No double spacing please
@@ +62,5 @@
> +
> +## LOCALIZATION NOTE(newsblog-confirmUpdate):
> +## %1$S is the folder, %2$S is the feed url, %3$S is the number of items in
> an updating feed.
> +newsblog-confirmUpdate=The feed in %1$S and location %2$S contains %3$S
> items. Continue?
> +
no double spacing
::: mailnews/extensions/newsblog/content/Feed.js
@@ +204,2 @@
> let lastModifiedHeader = request.getResponseHeader("Last-Modified");
> + feed.mLastModified = lastModifiedHeader && feed.parseItems ?
I personally prefer () around ternary expressions, for clarity. Others
may disagree...
::: mailnews/extensions/newsblog/content/utils.js
@@ +84,5 @@
> // There are no new articles for this feed
> kNewsBlogNoNewItems: 4,
> + kNewsBlogCancel: 5,
> +
> + HIGH_COUNT_LIMIT_SUBSCRIBE: 100,
100 sounds like a fairly small limit, how about 500 or something? i
think i've seen valid feeds have way above 100
@@ +650,5 @@
> },
>
> +/**
> + * Prompt to continue a new subscribe if the item count is high.
> + *
trailing space
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/191006
Title:
Thunderbird RSS should have a per feed limit per download
To manage notifications about this bug go to:
https://bugs.launchpad.net/thunderbird/+bug/191006/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
