I'm a bit confused I don't see the changes to configure.in as mentioned in: https://hg.libsdl.org/SDL/rev/274017846e73
This is what the SRU Info above mentioned, yet the patch is different. Can either the SRU template be adjusted (if the patch uploaded is correct) or let us know if the current upload needs to be reworked before it is accepted. ** Description changed: + [Impact] + Projects that use libsdl2 might not compile due to issues with how SDL_syswm.h support MIR. + + [Test Case] + Try to compile openmw. + + [Regression Potential] + Patch is upstream: + https://hg.libsdl.org/SDL/rev/274017846e73 + And in Utopic. + This should _fix_ compilation errors. + + -- + I believe something is wrong with MIR support. A daily build of openmw just failed with: /usr/include/SDL2/SDL_syswm.h:97:44: fatal error: mir_toolkit/mir_client_library.h: No such file or directory #include <mir_toolkit/mir_client_library.h> In SDL_syswm.h: #if defined(SDL_VIDEO_DRIVER_MIR) #include <mir_toolkit/mir_client_library.h> #endif the file is: /usr/include/mirclient/mir_toolkit/mir_client_library.h http://packages.ubuntu.com/search?searchon=contents&keywords=mir_client_library.h&mode=exactfilename&suite=trusty&arch=any openmw buildlog: https://launchpadlibrarian.net/172588668/buildlog_ubuntu-trusty-i386.openmw_0.29%2Bgit20140411.77-0~ubuntu14.04.1_FAILEDTOBUILD.txt.gz it built successfully until the fix for bug #1295389 libsdl2 commit hit that enabled mir. Assigning "high" since it has the potentially to cause a large number of FTBFS in the archive. SRU Info: *Note* This patch has landed in libsdl2 upstream: https://hg.libsdl.org/SDL/rev/274017846e73 1) The issue is we include mir_client_library.h, meaning everything that compiles sdl2 apps will need to include this as well. So we need to forward declare the structs so we don't need to include the mir header. 2) A simple way to test the current Mir problem: http://paste.ubuntu.com/7271077/ 3) Regression potential: Very low, this is a 1 line patch, that adds the MIR_CFLAGS to the SDL_CFLAGS. ** Description changed: - [Impact] - Projects that use libsdl2 might not compile due to issues with how SDL_syswm.h support MIR. - - [Test Case] - Try to compile openmw. - - [Regression Potential] - Patch is upstream: - https://hg.libsdl.org/SDL/rev/274017846e73 - And in Utopic. - This should _fix_ compilation errors. - - -- - I believe something is wrong with MIR support. A daily build of openmw just failed with: /usr/include/SDL2/SDL_syswm.h:97:44: fatal error: mir_toolkit/mir_client_library.h: No such file or directory #include <mir_toolkit/mir_client_library.h> In SDL_syswm.h: #if defined(SDL_VIDEO_DRIVER_MIR) #include <mir_toolkit/mir_client_library.h> #endif the file is: /usr/include/mirclient/mir_toolkit/mir_client_library.h http://packages.ubuntu.com/search?searchon=contents&keywords=mir_client_library.h&mode=exactfilename&suite=trusty&arch=any openmw buildlog: https://launchpadlibrarian.net/172588668/buildlog_ubuntu-trusty-i386.openmw_0.29%2Bgit20140411.77-0~ubuntu14.04.1_FAILEDTOBUILD.txt.gz it built successfully until the fix for bug #1295389 libsdl2 commit hit that enabled mir. Assigning "high" since it has the potentially to cause a large number of FTBFS in the archive. SRU Info: + [Impact] + Projects that use libsdl2 might not compile due to issues with how SDL_syswm.h support MIR. + + [Test Case] + Try to compile openmw. + + [Regression Potential] + *Note* This patch has landed in libsdl2 upstream: https://hg.libsdl.org/SDL/rev/274017846e73 1) The issue is we include mir_client_library.h, meaning everything that compiles sdl2 apps will need to include this as well. So we need to forward declare the structs so we don't need to include the mir header. 2) A simple way to test the current Mir problem: http://paste.ubuntu.com/7271077/ 3) Regression potential: Very low, this is a 1 line patch, that adds the MIR_CFLAGS to the SDL_CFLAGS. ** Description changed: I believe something is wrong with MIR support. A daily build of openmw just failed with: /usr/include/SDL2/SDL_syswm.h:97:44: fatal error: mir_toolkit/mir_client_library.h: No such file or directory #include <mir_toolkit/mir_client_library.h> In SDL_syswm.h: #if defined(SDL_VIDEO_DRIVER_MIR) #include <mir_toolkit/mir_client_library.h> #endif the file is: /usr/include/mirclient/mir_toolkit/mir_client_library.h http://packages.ubuntu.com/search?searchon=contents&keywords=mir_client_library.h&mode=exactfilename&suite=trusty&arch=any openmw buildlog: https://launchpadlibrarian.net/172588668/buildlog_ubuntu-trusty-i386.openmw_0.29%2Bgit20140411.77-0~ubuntu14.04.1_FAILEDTOBUILD.txt.gz it built successfully until the fix for bug #1295389 libsdl2 commit hit that enabled mir. Assigning "high" since it has the potentially to cause a large number of FTBFS in the archive. SRU Info: - [Impact] - Projects that use libsdl2 might not compile due to issues with how SDL_syswm.h support MIR. - - [Test Case] - Try to compile openmw. - - [Regression Potential] *Note* This patch has landed in libsdl2 upstream: https://hg.libsdl.org/SDL/rev/274017846e73 1) The issue is we include mir_client_library.h, meaning everything that compiles sdl2 apps will need to include this as well. So we need to forward declare the structs so we don't need to include the mir header. 2) A simple way to test the current Mir problem: http://paste.ubuntu.com/7271077/ - 3) Regression potential: Very low, this is a 1 line patch, that adds the MIR_CFLAGS to the SDL_CFLAGS. + + 3) Regression potential: Very low, this is a 1 line patch, that adds the + MIR_CFLAGS to the SDL_CFLAGS. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1306629 Title: [SRU] SDL_syswm.h can't find mir_toolkit/mir_client_library.h To manage notifications about this bug go to: https://bugs.launchpad.net/mir/+bug/1306629/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
