Thanks for the review. Please see my comments inline. - data/system.conf had wide-open dbus config I don't know if this is an issue or not -- I suspect it is fine, but I wanted to make sure it was raised all the same
The file was used in testing before dbus-cpp offered a complete testing solution including sane fixtures for setting up bus instances for testing purposes. Removed both configuration files. - handle_add_query() thread-unsafe This may also be fine, but I felt it ought to be mentioned Good catch, but not an issue right now as the underlying reactor is executed on a single thread and requests are handled in a serial manner. - Directory() is created mode 0777 This should change to 0755; perhaps 0700. Fixed. ** Branch linked: lp:~thomas-voss/trust-store/fix-mir-comments -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1338587 Title: [MIR] trust-store To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/trust-store/+bug/1338587/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
