Hey Chris! Thanks for the tarball and packaging. So far the changes look pretty sane and the package builds correctly. I have a few questions before uploading this - note that some might be obvious, but due to the fact that I'm not a maintainer of this package I need to ask those.
First thing: I noticed you removed two lines in the override_dh_auto_test part of debian/rules, and therefore it seems that no tests are now being ran during package build. We cannot allow to upload a new package to the archive with its tests disabled without any reason. Is there a reason for that to be happening here? I suppose the 0.8.0 version still has some unit tests. The other smaller things: - We would need to think about getting this to Debian as well - Did you test that the new version does not break any of its reverse-dependencies? I saw a few packages build-depend on it, so I would feel safer actually if you made sure there's no API breakge here -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1400512 Title: should be upgraded to unittest2=>0.8.0 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/python-unittest2/+bug/1400512/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
