Hi @raharper,
Thanks for the review.
> ------- Comment From raharper 2016-04-04 23:25:18 UTC-------
> Hello,
>
> Thanks for sending the debdiff. Have you filed bugs against debian for
> these issues? ie are they present in debian unstable at this point or are we
> bringing in known fixes from debian?
I couldn't look at Debian multipath-tools for a while.
afaik the code for removing partitions nodes was not shipped in Debian,
so it shouldn't be affected.
Back then I've submitted to Debian the changes to support 'udev property
blacklisting' correctly, like the one for sg3-utils udev rules to be
shipped. But couldn't keep up so far.
> 1) for find-multipaths, we dropped the patch in the merge since it was
> already applied in Debian, however, it was not enabled by default. Is it
> required that we modify defaults.h ? or is it sufficient to include:
As far as I can see it was enabled by default in the removed patch
'add_find-multipaths.patch' [1]
"""
-In addition, one further modification from the original patch from fedora
-packaging git was done: default for find_multipaths was set to enabled
...
-+#define DEFAULT_FIND_MULTIPATHS 1
""'
And this patch changed it from 0 () to 1.
+-#define DEFAULT_FIND_MULTIPATHS 0
++#define DEFAULT_FIND_MULTIPATHS 1
>
> find_multipaths "yes" in the multipath.conf ?
Yes, it would be sufficient to include 'find_multipaths "yes"' in the
defaults section of multipath.conf.
> 2) local-premount: fix for #1561103 seems reasonable
Cool.
Just clarifying the importance of this -- the lack of -B causes that multipath
call in the initramfs to select an alias that may differ to that in the
rootfs, and when the rename is attempted by the rootfs, you get disk corruption
(hit that in my kvm guest). We've started to ship the /etc/multipath/bindings
from the installer to the installed rootfs because of that.
> 3) local-top: it appears that you're migrating much of what local-top does
> into init-top. Why? I see, notes in the bug;
> We'll need to fix up the changelog to include the reason for the migration
> (necessitated by the use of multipath -u
Sure. It was mainly because the code snippets in it became redundant or
unnecessary w/ the recent changes; they are:
1) Start multipathd -- now done in init-top (as part of the 'multipath
-c/-u' change).
2) Load modules -- already done in init-top (which loads scsi device
handlers, and had to load dm-multipath already.. so it was just a matter
of moving the one remaining/incorrectly named module from local-top into
init-top)
3) Settle for udev events - this was required when multipath discovery
was performed in udev rules, which is no longer the case since we
introduced multipathd in the initramfs.. and the second call was
performed for the same reason that we introduced an udevadm settle in
local-premount (wait for symlinks). Since it's already present in local-
premount now, we can drop this one.
> Could you include the guest XML (or qemu commandline) you used to find the
> bug and verify it fixed with this debdiff?
The bug was found in a PowerVM LPAR w/ IBM virtual FibreChannel w/ VIOS,
but is reproducible w/ a qemu-kvm guest, which I guess you too would
prefer for debugging this issue (it's just simpler :)
qemu-system-ppc64 \
-enable-kvm \
-nographic -nodefaults \
-monitor stdio -serial pty \
-M pseries -smp 1,cores=1,threads=1 -m 8G \
-device spapr-vlan,netdev=net0,mac=4C:45:42:45:02:02 \
-netdev bridge,id=net0,br=br0 \
-drive file=mauricfo-1604-apr1.qcow2,serial=xenialroot \
-drive file=mauricfo-1604-apr1.qcow2,serial=xenialroot \
-drive file=disk-other.qcow2 \
-drive media=cdrom,file=xenial-server-ppc64el_2016-04-01.iso
[1]
https://launchpadlibrarian.net/249714939/multipath-tools_0.5.0-7ubuntu16_0.5.0+git1.656f8865-5ubuntu1.diff.gz
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1565817
Title:
multipath: LVM physical volumes on individual paths
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/multipath-tools/+bug/1565817/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
