I tracked down the source of the issue

The current patch modifies the addHeader() function itself to perform
the check, this is invalid because this function is used internally to
setup many headers from the environment such as the standard CGI
HTTP_HOST, REQUEST_URI, etc.

The correct patch should only abort adding headers from the HTTP
request.


The upstream patch/source for Passenger 5 was quite different to v2 here, 
however the upstream patch for Passenger 4 
(https://github.com/phusion/passenger/commit/c04590871ca0878d4d3ac1220c5a554b049056b4)
 was very similar and I have backported this fix to precise in the attached 
debdiff.  I have not backported the nginx part, it was not done originally.

Patch Testing:
 ** No Patch **
lathiat@ubuntu:~/src/lp1575220$ curl -s -H "X-Test-Dash-Header: Yes" -H 
"X_TEST_UNDERSCORE_HEADER: Yes" http://10.48.134.78/|grep -i test
   "HTTP_X_TEST_UNDERSCORE_HEADER"=>"Yes",
   "HTTP_X_TEST_DASH_HEADER"=>"Yes",

 ** Broken Patch **
lathiat@ubuntu:~/src/lp1575220$ curl -s -H "X-Test-Dash-Header: Yes" -H 
"X_Test_Underscore_header: Yes" http://10.48.134.78/|grep -i test

 ** New Proposed Patch **
lathiat@ubuntu:~/src/lp1575220$ curl -s -H "X-Test-Dash-Header: Yes" -H 
"X_Test_Underscore_header: Yes" http://10.48.134.78/|grep -i test
   "HTTP_X_TEST_DASH_HEADER"=>"Yes",

** Patch added: "lp1575220-against-12.04.1.diff"
   
https://bugs.launchpad.net/ubuntu/+source/passenger/+bug/1575220/+attachment/4695470/+files/lp1575220-against-12.04.1.diff

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1575220

Title:
  puppet broken after libapache2-mod-passenger upgrade

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/passenger/+bug/1575220/+subscriptions

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to