Blockers:
- Needs a proper team LP bug subscriber.
Questions:
- acceptance and http13client tests are skipped during debuild. Why?
Do the http tests actually try to hit the network, instead of setting up
a mock http server?
- What's the story with bug 1475612, are we ftbfs in some cases?
Non blocking notes:
- There are a lot of warnings during test runs. Presumably ignorable,
but it would be hard to notice something that wasn't ignorable among all
the chaff.
- "DEB_BUILD_OPTIONS := nocheck" in debian/rules doesn't do anything,
because the given override_dh_auto_test rules doesn't look for nocheck,
it only looks at testskip_architectures. I suspect that line can be
removed.
- "${misc:Depends}" should be added to ubuntu-push-autopilot's Depends.
It's empty now, so it's not a big deal. But for cleanliness and in case
in the future it isn't empty...
- This is an Ubuntu-centric package and we're not worried about being in
sync with Debian, so I'm not going to block on this, but the -dev
package name is wrong. According to Debian Go packaging guidelines [1],
it should be golang-launchpad-ubuntu-push-dev. (i.e. we're currently
missing the 'launchpad').
- This will need a security look at some point before the LTS, but the
security team doesn't want to block this MIR on that.
- You can't currently debuild twice in a row because the clean target
doesn't properly clean signing-helper/. It might help if you changed
the build override to run cmake into a special build dir and installed
the signing helper from that dir in ubuntu-push-client.install. Then
add a clean override to get rid of that build dir.
[1] http://pkg-go.alioth.debian.org/packaging.html
Answers:
- You weren't sure about debconf. It's just a system that some
packages use to ask a user to make a choice during package install (or
upgrade). They are generally something we try to avoid, since it's a
bad user experience. Most packages don't have them.
- You weren't sure about debian/watch. It's a file that some packages
have that describe where upstream tarballs are. That way, a package
developer can use "uscan" to see if there's a new update for the
package. And so can automated tools. Mostly useful when you a
packaging a separate upstream rather than like this package, where we
are the upstream.
** Changed in: ubuntu-push (Ubuntu)
Status: New => Incomplete
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1612638
Title:
[MIR] ubuntu-push
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-push/+bug/1612638/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
