> Needs a proper team LP bug subscriber.
Will subscribe phablet-team.
> acceptance and http13client tests are skipped during debuild. Why? Do the
> http tests actually try to hit the network, instead of setting up a mock http
> server?
Why acceptance is skipped I don't know, I'll have to refer you to John and
Samuele. Why the http13client test even exist, is due to the fact that the 1.2
client was too buggy, so 1.3 was backported, which included the tests. I can,
when time, check out if we still run 1.2 anywhere (I fear we do).
> What's the story with bug 1475612, are we ftbfs in some cases?
I've requested information from the reporter, but I haven't seen a ftbfs like
that.
> There are a lot of warnings during test runs. Presumably ignorable, but it
> would be hard to notice something that wasn't ignorable among all the chaff.
It's super hard, will see if there's an easy fix to this.
> "${misc:Depends}" should be added to ubuntu-push-autopilot's Depends. It's
> empty now, so it's not a big deal. But for cleanliness and in case in the
> future it isn't empty...
Ack.
> This is an Ubuntu-centric package and we're not worried about being in sync
> with Debian, so I'm not going to block on this, but the -dev package name is
> wrong. According to Debian Go packaging guidelines [1], it should be
> golang-launchpad-ubuntu-push-dev. (i.e. we're currently missing the
> 'launchpad').
Okay, will change.
> You can't currently debuild twice in a row because the clean target doesn't
> properly clean signing-helper/. It might help if you changed the build
> override to run cmake into a special build dir and installed the signing
> helper from that dir in ubuntu-push-client.install. Then add a clean override
> to get rid of that build dir.
Right, that seemed hacky to me too, so will take a look at improving that.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1612638
Title:
[MIR] ubuntu-push
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-push/+bug/1612638/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
