The easiest way would be to simply disable the -Werror=deprecated-
declarations and see how this goes, but the *proper* fix would be to get
rid of the deprecated functions and use the new, proper ones instead. I
leave the decision how to proceed to the upstream developers.

Anyway, I propose a merge to fix the first part of the problem.

** Summary changed:

- Package FTBFS because of missing gnome-common dependency
+ Package FTBFS

** Branch linked: lp:~sil2100/bamf/fix_ftbfs_dep

** Description changed:

+ There are two issues that cause the package to FTBFS during rebuilds.
+ First one is the missing gnome-common build-dependency:
+ 
  make[1]: Entering directory '/<<BUILDDIR>>/bamf-0.5.3+16.10.20160929'
  NOCONFIGURE=1 dh_autoreconf ./autogen.sh
  You need to install the gnome-common module and make
  sure the gnome-autogen.sh script is in your $PATH.
  dh_autoreconf: ./autogen.sh returned exit code 1
  debian/rules:11: recipe for target 'override_dh_autoreconf' failed
  make[1]: *** [override_dh_autoreconf] Error 2
  make[1]: Leaving directory '/<<BUILDDIR>>/bamf-0.5.3+16.10.20160929'
  debian/rules:8: recipe for target 'build-arch' failed
  make: *** [build-arch] Error 2
  dpkg-buildpackage: error: debian/rules build-arch gave error exit status 2
+ 
+ But even after this dependency is satisfied, the build seems to fail on
+ use of some deprecated functions in the code. One example:
+ 
+ bamf-legacy-window.c: In function 'top_window_action_menu':
+ bamf-legacy-window.c:548:3: error: 'gdk_screen_get_monitor_scale_factor' is 
deprecated: Use 'gdk_monitor_get_scale_factor' instead 
[-Werror=deprecated-declarations]
+    scale = gdk_screen_get_monitor_scale_factor (gdk_screen_get_default (), 0);
+    ^~~~~
+ In file included from /usr/include/gtk-3.0/gdk/gdkapplaunchcontext.h:31:0,
+                  from /usr/include/gtk-3.0/gdk/gdk.h:32,
+                  from /usr/include/gtk-3.0/gtk/gtk.h:30,
+                  from /usr/include/libwnck-3.0/libwnck/pager.h:29,
+                  from /usr/include/libwnck-3.0/libwnck/libwnck.h:32,
+                  from bamf-legacy-window.h:30,
+                  from bamf-legacy-window.c:23:
+ /usr/include/gtk-3.0/gdk/gdkscreen.h:103:15: note: declared here
+  gint          gdk_screen_get_monitor_scale_factor (GdkScreen *screen,
+                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+ bamf-legacy-window.c: In function 'bamf_legacy_window_show_action_menu':
+ bamf-legacy-window.c:609:3: error: 'gtk_menu_popup' is deprecated: Use 
'(gtk_menu_popup_at_widget, gtk_menu_popup_at_pointer, gtk_menu_popup_at_rect)' 
instead [-Werror=deprecated-declarations]
+    gtk_menu_popup (GTK_MENU (menu), NULL, NULL, position, self, button, time);
+    ^~~~~~~~~~~~~~
+ In file included from /usr/include/gtk-3.0/gtk/gtklabel.h:34:0,
+                  from /usr/include/gtk-3.0/gtk/gtkaccellabel.h:35,
+                  from /usr/include/gtk-3.0/gtk/gtk.h:33,
+                  from /usr/include/libwnck-3.0/libwnck/pager.h:29,
+                  from /usr/include/libwnck-3.0/libwnck/libwnck.h:32,
+                  from bamf-legacy-window.h:30,
+                  from bamf-legacy-window.c:23:
+ /usr/include/gtk-3.0/gtk/gtkmenu.h:138:9: note: declared here
+  void    gtk_menu_popup    (GtkMenu        *menu,
+          ^~~~~~~~~~~~~~
+ cc1: all warnings being treated as errors

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1680104

Title:
  Package FTBFS

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/bamf/+bug/1680104/+subscriptions

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to