Hi Sebastien, 
Thanks for your review, there are some reasons to take the bumping version 
patch.

1. to verify which patches in libqmi is needed , it need a known worked
modemmanager and libmbim (yakkety version) help, and there are version
check both in configure and build dependency.

2. looks the bumping version action was took by upstream when a big
change like this qmi-over-mbim. So, people might expect qmi-over-mbim
should not be there before such version. So, I was confused about should
I keep the bumped version there to keep this expectation synced.

All patches were picked up by git bisect method in the environment setting of 
point 1, then install all backported packages together for a sanity check in 
final.
And the decision to keep the version bumping was made based on point 2.

In another side about why not just take whole new version:
by roughly diff of libqmi, 
changed no. of lines of backport patches to xenial libqmi-glib1-1.12.6-1
1791

changed no. of lines of xenial libqmi-glib1-1.12.6-1 to yakkety libqmi 1.16.0-1
142332

And just taking new version would introduce more changes in libmbim and
modemmanager which not related to qmi-over-mbim for DW5816 by just take
yakkety libqmi 1.16.0-1.

So, the idea is fewer changes might have higher SRU possibility.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1693756

Title:
  [Xenial][ DW5816e] to support qmi over mbim which needed for FCC
  authentication.

To manage notifications about this bug go to:
https://bugs.launchpad.net/modemmanager/+bug/1693756/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to