@Manoj: While the code in the patch looks fine, I do see a couple issues with the DEP-3 headers:
>Description: Remove version from list > We can't reliably map controller registers due to kernel memory > protections added in kernel commit 90a545e98, so we are removing its > dependency for the 'list' command to run. > Author: Keith Busch <[email protected]> I'd suggest starting with the git commit, including all the metadata, and adding the DEP-3 specific fields (Origin, Bug) to the end of the header. > Origin: upstream, https://github.com/linux-nvme/nvme-cli Origin should be the URL of the commit, not the repository. > Bug: https://launchpad.net/bugs/## This isn't a valid URL, and it should be a pointer to the upstream bug, if one exists. The "Bug-Ubuntu" field should be used to provide a pointer to the Ubuntu bug in LP. > Forwarded: not-needed Well, technically it *is* needed since it was applied upstream. I'd suggest just omitting this field though, it only really makes sense if it is a vendor-specific patch. ** Changed in: nvme-cli (Ubuntu Xenial) Assignee: (unassigned) => Manoj Iyer (manjo) ** No longer affects: nvme-cli (Ubuntu Zesty) ** Changed in: nvme-cli (Ubuntu Xenial) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1704817 Title: [Xenial] nvme-cli does not recognize version 1.0 NVME drives To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/nvme-cli/+bug/1704817/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
