This debdiff looks mostly good. I had to spend quite a bit of time to
figure out where the patches came from. Apparently, they're from this
bug:

  https://issues.asterisk.org/jira/browse/DAHLIN-359

I've added the Origin dep-3 tag to each patch. I see that you probably
just reused the patches from the Bionic or Cosmic  package, which didn't
include the origin, but the origin is important to include so that we
know where the code is coming from, what kind of review it has gotten,
etc.

As mentioned while sponsoring another recent package for you, I don't
love the SRU versioning scheme used here. If you look at the current
artful, bionic, and cosmic version strings, you can see why it could be
a problem in future SRUs. The versioning scheme documented here has been
proven to work well:

https://wiki.ubuntu.com/SecurityTeam/UpdatePreparation#Update_the_packaging

I'm sponsoring this one to xenial-proposed since you're following the
existing SRU versioning scheme for the package. Thanks for the debdiff!
:)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1779331

Title:
  dahdi-linux 1:2.10.2~dfsg-1ubuntu2 ADT test failure with linux-hwe-
  edge 4.15.0-23.25~16.04.1

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/dahdi-linux/+bug/1779331/+subscriptions

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to