Launchpad has imported 21 comments from the remote bug at https://bugzilla.xfce.org/show_bug.cgi?id=12062.
If you reply to an imported comment from within Launchpad, your comment will be sent to the remote bug automatically. Read more about Launchpad's inter-bugtracker facilities at https://help.launchpad.net/InterBugTracking. ------------------------------------------------------------------------ On 2015-07-11T06:19:37+00:00 2460acc wrote: When using FN key and arrows there are only 10 increments in the screen brightness settings. The lowest one is a black screen and the next one is already mid-bright for me. So basically it is not possible to set a low screen brightness level. Using xbacklight -dec 1 I have found there are 10 additional levels between the two xfce4-power-manager zero nd first level. Please can you let us access these. Reply at: https://bugs.launchpad.net/ubuntu/+source/xfce4-power- manager/+bug/1739805/comments/0 ------------------------------------------------------------------------ On 2015-07-11T07:58:05+00:00 2460acc wrote: The following lines in common/xfpm-brightness.c seem to be the cause of the course brightness steps. http://git.xfce.org/xfce/xfce4-power-manager/tree/common/xfpm- brightness.c 214 brightness->priv->step = max <= 20 ? 1 : max / 10; 366 brightness->priv->step = ret <= 20 ? 1 : ret / 10; I wonder if you could change these numbers to 20 or 30 to allow finer steps, e.g. brightness->priv->step = max <= 30 ? 1 : max / 30; I'm going to try and recompile but it looks a bit complicated for me. Reply at: https://bugs.launchpad.net/ubuntu/+source/xfce4-power- manager/+bug/1739805/comments/1 ------------------------------------------------------------------------ On 2015-07-18T17:45:48+00:00 2460acc wrote: I just saw there is something called: xfce4-settings-editor Perhaps you could put the number of steps as a parameter in there so users can do whatever they want. Reply at: https://bugs.launchpad.net/ubuntu/+source/xfce4-power- manager/+bug/1739805/comments/2 ------------------------------------------------------------------------ On 2016-01-24T19:10:34+00:00 Simon Steinbeiß wrote: *** Bug 12299 has been marked as a duplicate of this bug. *** Reply at: https://bugs.launchpad.net/ubuntu/+source/xfce4-power- manager/+bug/1739805/comments/3 ------------------------------------------------------------------------ On 2016-03-06T09:57:20+00:00 Timothy Lee wrote: I've made an attempt to add this feature. The code can be found on the brightness-step-count branch at: [email protected]:timothytylee/xfce4 -power-manager.git Please apply if the patch is acceptable. Reply at: https://bugs.launchpad.net/ubuntu/+source/xfce4-power- manager/+bug/1739805/comments/4 ------------------------------------------------------------------------ On 2016-03-07T06:30:29+00:00 Eric Koegel wrote: Timothy, nice work. Now that you have a configuration option in the settings UI, you can react to that in the power manager plugin as well. If we do it in the backlight, you'll need to create a step_switch variable in the struct then, install it in the class_init http://git.xfce.org/xfce/xfce4-power-manager/tree/src/xfpm-backlight.c#n313 Use xfconf_g_property_bind to be notified of changes. http://git.xfce.org/xfce/xfce4-power-manager/tree/src/xfpm-backlight.c#n368 Then you can call xfpm_brightness_set_step_count in the set_property function and return the step-size in the get function. http://git.xfce.org/xfce/xfce4-power-manager/tree/src/xfpm-backlight.c#n444 Reply at: https://bugs.launchpad.net/ubuntu/+source/xfce4-power- manager/+bug/1739805/comments/5 ------------------------------------------------------------------------ On 2016-03-07T17:35:38+00:00 Eric Koegel wrote: Ugh, that's what I get for commenting before coffee. For the panel plugin you'll want to do something similar what the brightness_min_level does in the panel-plugins/power-manager-plugin/power-manager-button.c Hope I'm not too confusing. Reply at: https://bugs.launchpad.net/ubuntu/+source/xfce4-power- manager/+bug/1739805/comments/6 ------------------------------------------------------------------------ On 2016-03-08T00:20:06+00:00 Timothy Lee wrote: I believe the panel plugin doesn't need to be updated, since changing the number of keyboard controllable steps doesn't affect current brightness -- it only affects future brightness adjustment made by keyboard. Reply at: https://bugs.launchpad.net/ubuntu/+source/xfce4-power- manager/+bug/1739805/comments/7 ------------------------------------------------------------------------ On 2016-05-06T20:09:17+00:00 2460acc wrote: I wonder if you could make the increments logarithmic? I.e. 1, 2, 4, 6, 16. etc. On my screen, with linear steps the gaps are too large at the low levels (ie, the screen gets too bright too quickly) but then at the high levels there are too many steps needed to get to full brightness. In terms of steps, something like 0, 1, 2, 3, 4, 5, 10, 20, 50, 75, 100 % would give fine control where you need it but you can also get to max brightness easily as well. Thanks for your help! Really appreciated. Reply at: https://bugs.launchpad.net/ubuntu/+source/xfce4-power- manager/+bug/1739805/comments/8 ------------------------------------------------------------------------ On 2016-07-28T11:16:07+00:00 Timothy Lee wrote: I've finished implementing the brightness step count functionality. In addition to the git repository, I'm attaching a patch. Reply at: https://bugs.launchpad.net/ubuntu/+source/xfce4-power- manager/+bug/1739805/comments/9 ------------------------------------------------------------------------ On 2016-07-28T11:17:11+00:00 Timothy Lee wrote: Created attachment 6754 Adjustable brightness steps Reply at: https://bugs.launchpad.net/ubuntu/+source/xfce4-power- manager/+bug/1739805/comments/10 ------------------------------------------------------------------------ On 2016-07-29T10:49:42+00:00 zetxx wrote: (In reply to Timothy Lee from comment #10) > Created attachment 6754 [details] > Adjustable brightness steps to which package should be applied this patch ? because i cannot see edited file in xfce4-power-manager Reply at: https://bugs.launchpad.net/ubuntu/+source/xfce4-power- manager/+bug/1739805/comments/11 ------------------------------------------------------------------------ On 2016-07-29T12:56:07+00:00 Timothy Lee wrote: I've added an option to toggle exponential step sizes. Reply at: https://bugs.launchpad.net/ubuntu/+source/xfce4-power- manager/+bug/1739805/comments/12 ------------------------------------------------------------------------ On 2016-07-29T12:56:56+00:00 Timothy Lee wrote: Created attachment 6757 Adjustable brightness steps with support for exponential step sizes Reply at: https://bugs.launchpad.net/ubuntu/+source/xfce4-power- manager/+bug/1739805/comments/13 ------------------------------------------------------------------------ On 2016-07-29T12:59:47+00:00 Timothy Lee wrote: This patch is applicable to the master branch of xfce4-power-manager at http://git.xfce.org/xfce/xfce4-power-manager/ Reply at: https://bugs.launchpad.net/ubuntu/+source/xfce4-power- manager/+bug/1739805/comments/14 ------------------------------------------------------------------------ On 2016-07-29T18:24:58+00:00 zetxx wrote: thanks Reply at: https://bugs.launchpad.net/ubuntu/+source/xfce4-power- manager/+bug/1739805/comments/15 ------------------------------------------------------------------------ On 2016-08-30T07:42:02+00:00 Timothy Lee wrote: Ping. Any comments on the patch? Reply at: https://bugs.launchpad.net/ubuntu/+source/xfce4-power- manager/+bug/1739805/comments/16 ------------------------------------------------------------------------ On 2017-01-14T11:09:31+00:00 2460acc wrote: The latest versions (up to 1.6) still have the original code with the brain-dead step increment. https://github.com/xfce-mirror/xfce4-power-manager/releases What exactly is the point of this bug tracker? Logarithmic increments can be implemented with very little modification in common/xfpm-brightness.c. Look for "set_level =" and use the following for decrement and increment, respectively. set_level = MAX (hw_level/2, brightness->priv->min_level); set_level = MIN (hw_level*2 + (hw_level==0), brightness->priv->max_level ); I hope someone finds this useful... if anyone is even out there! Reply at: https://bugs.launchpad.net/ubuntu/+source/xfce4-power- manager/+bug/1739805/comments/17 ------------------------------------------------------------------------ On 2017-01-22T08:41:41+00:00 2460acc wrote: Works even better with a smaller decrement value, so you can access in- between values. set_level = MAX (hw_level/1.5, brightness->priv->min_level); Reply at: https://bugs.launchpad.net/ubuntu/+source/xfce4-power- manager/+bug/1739805/comments/18 ------------------------------------------------------------------------ On 2017-12-03T18:16:15+00:00 Marcel Partap wrote: Yes, please @maintainer integrate this into the next update : ) Reply at: https://bugs.launchpad.net/ubuntu/+source/xfce4-power- manager/+bug/1739805/comments/19 ------------------------------------------------------------------------ On 2018-05-12T12:42:40+00:00 Timothy Lee wrote: Created attachment 7728 Adjustable brightness steps with support for exponential step sizes Updated patch again for master branch of xfce4-power-manager at http://git.xfce.org/xfce/xfce4-power-manager/ Reply at: https://bugs.launchpad.net/ubuntu/+source/xfce4-power- manager/+bug/1739805/comments/23 ** Changed in: xfce4-power-manager Status: Unknown => Confirmed ** Changed in: xfce4-power-manager Importance: Unknown => Medium -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1739805 Title: Backlight tuning has not enough steps To manage notifications about this bug go to: https://bugs.launchpad.net/xfce4-power-manager/+bug/1739805/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
