** Description changed:

+ [Impact]
+ 
+  * An explanation of the effects of the bug on users and
+ 
+  * justification for backporting the fix to the stable release.
+ 
+  * In addition, it is helpful, but not required, to include an
+    explanation of how the upload fixes this bug.
+ 
+ [Test Case]
+ 
+  * detailed instructions how to reproduce the bug
+ 
+  * these should allow someone who is not familiar with the affected
+    package to reproduce the bug and verify that the updated package fixes
+    the problem.
+ 
+ [Regression Potential]
+ 
+  * discussion of how regressions are most likely to manifest as a result
+ of this change.
+ 
+  * It is assumed that any SRU candidate patch is well-tested before
+    upload and has a low overall risk of regression, but it's important
+    to make the effort to think about what ''could'' happen in the
+    event of a regression.
+ 
+  * This both shows the SRU team that the risks have been considered,
+    and provides guidance to testers in regression-testing the SRU.
+ 
+ [Other Info]
+  
+  * Anything else you think is useful to include
+  * Anticipate questions from users, SRU, +1 maintenance, security teams and 
the Technical Board
+  * and address these questions in advance
+ 
+ 
+ [Original Description]
+ 
  There is an FTBFS with boost1.67 in cosmic that is fixed in disco via
  this patch[1]:
  
  From fdbdb94db64e888fce90fe519be23c2a4396a82e Mon Sep 17 00:00:00 2001
  From: pradeep <[email protected]>
  Date: Tue, 8 May 2018 14:53:38 +0530
  Subject: [PATCH 1/2] Fix return var qualifier in svm_ptr::get_context
  
  Lack of `const` qualifier is throwing errors with GCC 8.1
  ---
-  include/boost/compute/memory/svm_ptr.hpp | 2 +-
-  1 file changed, 1 insertion(+), 1 deletion(-)
+  include/boost/compute/memory/svm_ptr.hpp | 2 +-
+  1 file changed, 1 insertion(+), 1 deletion(-)
  
  diff --git a/include/boost/compute/memory/svm_ptr.hpp 
b/include/boost/compute/memory/svm_ptr.hpp
  index c8753f5b..56cf1268 100644
  --- a/libs/compute/include/boost/compute/memory/svm_ptr.hpp
  +++ b/libs/compute/include/boost/compute/memory/svm_ptr.hpp
  @@ -126,7 +126,7 @@ class svm_ptr
-          return m_ptr - other.m_ptr;
-      }
-  
+          return m_ptr - other.m_ptr;
+      }
+ 
  -    context& get_context() const
  +    const context& get_context() const
-      {
-          return m_context;
-      }
- 
+      {
+          return m_context;
+      }
  
  1. https://git.launchpad.net/~usd-import-
  team/ubuntu/+source/boost1.67/tree/debian/patches/fix-boost-compute-
  gcc8-ftbfs.patch?h=ubuntu/disco-devel

** Description changed:

  [Impact]
  
-  * An explanation of the effects of the bug on users and
+ There is an FTBFS with boost1.67 in cosmic that is fixed in disco
+ already via this patch[1].
  
-  * justification for backporting the fix to the stable release.
+ This FTBFS prevents boost1.67 in cosmic from ever being SRUed. Such an
+ SRU need has showed up[2].
  
-  * In addition, it is helpful, but not required, to include an
-    explanation of how the upload fixes this bug.
  
  [Test Case]
+ Build boost1.67 in cosmic. Without this fix, the build fails.
  
-  * detailed instructions how to reproduce the bug
- 
-  * these should allow someone who is not familiar with the affected
-    package to reproduce the bug and verify that the updated package fixes
-    the problem.
  
  [Regression Potential]
- 
-  * discussion of how regressions are most likely to manifest as a result
- of this change.
- 
-  * It is assumed that any SRU candidate patch is well-tested before
-    upload and has a low overall risk of regression, but it's important
-    to make the effort to think about what ''could'' happen in the
-    event of a regression.
- 
-  * This both shows the SRU team that the risks have been considered,
-    and provides guidance to testers in regression-testing the SRU.
+ Patch is applied upstream and in disco already. Bug was caused by newly 
introduced gcc8 checks, and one such check is being fixed.
  
  [Other Info]
-  
-  * Anything else you think is useful to include
-  * Anticipate questions from users, SRU, +1 maintenance, security teams and 
the Technical Board
-  * and address these questions in advance
+ Not at this time.
  
  
  [Original Description]
  
  There is an FTBFS with boost1.67 in cosmic that is fixed in disco via
  this patch[1]:
  
  From fdbdb94db64e888fce90fe519be23c2a4396a82e Mon Sep 17 00:00:00 2001
  From: pradeep <[email protected]>
  Date: Tue, 8 May 2018 14:53:38 +0530
  Subject: [PATCH 1/2] Fix return var qualifier in svm_ptr::get_context
  
  Lack of `const` qualifier is throwing errors with GCC 8.1
  ---
   include/boost/compute/memory/svm_ptr.hpp | 2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)
  
  diff --git a/include/boost/compute/memory/svm_ptr.hpp 
b/include/boost/compute/memory/svm_ptr.hpp
  index c8753f5b..56cf1268 100644
  --- a/libs/compute/include/boost/compute/memory/svm_ptr.hpp
  +++ b/libs/compute/include/boost/compute/memory/svm_ptr.hpp
  @@ -126,7 +126,7 @@ class svm_ptr
           return m_ptr - other.m_ptr;
       }
  
  -    context& get_context() const
  +    const context& get_context() const
       {
           return m_context;
       }
  
- 1. https://git.launchpad.net/~usd-import-
- team/ubuntu/+source/boost1.67/tree/debian/patches/fix-boost-compute-
- gcc8-ftbfs.patch?h=ubuntu/disco-devel
+ 1. 
https://git.launchpad.net/~usd-import-team/ubuntu/+source/boost1.67/tree/debian/patches/fix-boost-compute-gcc8-ftbfs.patch?h=ubuntu/disco-devel
+ 2. https://bugs.launchpad.net/ubuntu/+source/boost1.67/+bug/1821762

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1821803

Title:
  FTBFS with gcc-8

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/boost1.67/+bug/1821803/+subscriptions

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to