** Description changed: + FFE Section + ----------- [Rationale] This change to mod_auth_mellon adds a very useful capability for enabling diagnostics output from the module: https://github.com/Uninett/mod_auth_mellon/commit/e8579f6387d9841ce619d836110050fb18117753 It is available as of v0.14.0 (present in Cosmic): git --no-pager tag --contains=e8579f6387d9841ce619d836110050fb18117753 v0.14.0 v0.14.1 This is generally useful for field engineering and operations teams and other users as SAML exchanges are difficult to debug. [Build Verification] https://paste.ubuntu.com/p/2kt3BsxJKn/ [Installation] https://paste.ubuntu.com/p/VcfcgyPHqH/ - - "MellonDiagnosticsEnable Off" is the default setting and it results in am_diag_open_log returning 1 which does NOT result in an error returned from am_diag_log_init. Also installed a package and verified that setting this to off explicitly or implicitly (default) does not result in errors on startup or page access. + "MellonDiagnosticsEnable Off" is the default setting and it results in + am_diag_open_log returning 1 which does NOT result in an error returned + from am_diag_log_init. Also installed a package and verified that + setting this to off explicitly or implicitly (default) does not result + in errors on startup or page access. https://git.launchpad.net/ubuntu/+source/libapache2-mod-auth- mellon/tree/auth_mellon_diagnostics.c?h=ubuntu/disco&id=49c8ccfedca2db17d76348573e6daa862e104f6d#n311 int am_diag_log_init(apr_pool_t *pc, apr_pool_t *p, apr_pool_t *pt, server_rec *s) { - for ( ; s ; s = s->next) { - if (!am_diag_open_log(s, p)) { - return HTTP_INTERNAL_SERVER_ERROR; - } - } + for ( ; s ; s = s->next) { + if (!am_diag_open_log(s, p)) { + return HTTP_INTERNAL_SERVER_ERROR; + } + } // ... - static int am_diag_open_log(server_rec *s, apr_pool_t *p) { + static int am_diag_open_log(server_rec *s, apr_pool_t *p) { // ... - if (!(diag_cfg->flags & AM_DIAG_FLAG_ENABLED)) { - ap_log_error(APLOG_MARK, APLOG_DEBUG, 0, s, - "mellon diagnostics disabled for %s", server_desc); - return 1; + if (!(diag_cfg->flags & AM_DIAG_FLAG_ENABLED)) { + ap_log_error(APLOG_MARK, APLOG_DEBUG, 0, s, + "mellon diagnostics disabled for %s", server_desc); + return 1; // ... [Upgrades] No impact + + + SRU section + ----------- + [Impact] + See FFE Rationale above. + + [Test Case] + + [Regression Potential] + As mentioned above in the FFE section, "MellonDiagnosticsEnable Off" can be set in the apache configuration to disable diagnostics. This is also the default setting, so regression potential is certainly limited by this.
** Description changed: - FFE Section - ----------- + FFE Section for disco + --------------------- [Rationale] This change to mod_auth_mellon adds a very useful capability for enabling diagnostics output from the module: https://github.com/Uninett/mod_auth_mellon/commit/e8579f6387d9841ce619d836110050fb18117753 It is available as of v0.14.0 (present in Cosmic): git --no-pager tag --contains=e8579f6387d9841ce619d836110050fb18117753 v0.14.0 v0.14.1 This is generally useful for field engineering and operations teams and other users as SAML exchanges are difficult to debug. [Build Verification] https://paste.ubuntu.com/p/2kt3BsxJKn/ [Installation] https://paste.ubuntu.com/p/VcfcgyPHqH/ "MellonDiagnosticsEnable Off" is the default setting and it results in am_diag_open_log returning 1 which does NOT result in an error returned from am_diag_log_init. Also installed a package and verified that setting this to off explicitly or implicitly (default) does not result in errors on startup or page access. https://git.launchpad.net/ubuntu/+source/libapache2-mod-auth- mellon/tree/auth_mellon_diagnostics.c?h=ubuntu/disco&id=49c8ccfedca2db17d76348573e6daa862e104f6d#n311 int am_diag_log_init(apr_pool_t *pc, apr_pool_t *p, apr_pool_t *pt, server_rec *s) { for ( ; s ; s = s->next) { if (!am_diag_open_log(s, p)) { return HTTP_INTERNAL_SERVER_ERROR; } } // ... static int am_diag_open_log(server_rec *s, apr_pool_t *p) { // ... if (!(diag_cfg->flags & AM_DIAG_FLAG_ENABLED)) { ap_log_error(APLOG_MARK, APLOG_DEBUG, 0, s, "mellon diagnostics disabled for %s", server_desc); return 1; // ... [Upgrades] No impact - SRU section ----------- [Impact] See FFE Rationale above. [Test Case] [Regression Potential] As mentioned above in the FFE section, "MellonDiagnosticsEnable Off" can be set in the apache configuration to disable diagnostics. This is also the default setting, so regression potential is certainly limited by this. ** Also affects: libapache2-mod-auth-mellon (Ubuntu Bionic) Importance: Undecided Status: New ** Also affects: libapache2-mod-auth-mellon (Ubuntu Disco) Importance: Undecided Status: New ** Also affects: libapache2-mod-auth-mellon (Ubuntu Cosmic) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1820279 Title: [FFe] [SRU] build mellon with --enable-diagnostics to ease up SSO debugging To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/libapache2-mod-auth-mellon/+bug/1820279/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
