Public bug reported:

[Impact] 
When libnuma-dev is installed on the build environment, tools/perf tries to 
build bench/numa.c, but in the current Xenial kernel in -proposed it fails:

  CC       bench/numa.o
bench/numa.c: In function 'lfsr_32':
bench/numa.c:729:24: error: implicit declaration of function 'BIT' 
[-Werror=implicit-function-declaration]
  const uint32_t taps = BIT(1) | BIT(5) | BIT(6) | BIT(31);
                        ^
bench/numa.c:729:2: error: nested extern declaration of 'BIT' 
[-Werror=nested-externs]
  const uint32_t taps = BIT(1) | BIT(5) | BIT(6) | BIT(31);
  ^


[Fix]
Commit "UBUNTU: SAUCE: perf/bench: Drop definition of BIT in numa.c", applied 
for "Xenial update: 4.4.180 upstream stable release (LP: #1830176)" is causing 
build failures on tools/perf/bench after stable upstream commit "perf tools: No 
need to include bitops.h in util.h" removed the inclusion of the header file 
where the BIT() macro is defined.

The fix is to revert the SAUCE patch and keep the definition of BIT() in
loco in numa.c as done in 4.4 stable upstream.


[Test Case]
1. Install libnuma-dev package on the build environment.
2. cd xenial/linux source directory.
3. fakeroot debian/rules clean
4. cd tools/perf
5. make


[Regression Potential] 
Low. The fix is to revert a SAUCE patch that was applied to fix a build failure 
that has been fixed upstream and it's not needed anymore.

** Affects: linux (Ubuntu)
     Importance: Undecided
         Status: Invalid

** Affects: linux (Ubuntu Xenial)
     Importance: Undecided
         Status: In Progress

** Also affects: linux (Ubuntu Xenial)
   Importance: Undecided
       Status: New

** Changed in: linux (Ubuntu Xenial)
       Status: New => In Progress

** Changed in: linux (Ubuntu)
       Status: New => Invalid

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1836585

Title:
  Xenial kernel 4.4.0-155.182 fails to build perf with libnuma

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1836585/+subscriptions

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to