Comment on attachment 9102584
1575512-glue.patch
Review of attachment 9102584:
-----------------------------------------------------------------
It's a pity we have to add these hacks for the current localization
infrastructure. But it is maybe also a bit unusual we cache strings in the
backend like this.
I like this non-simplified version better. It could be useful to have that
gInitializeStringsDone variable indicate if we think the strings are OK,
instead of blindly assuming they are (in the simplified version).
Thanks for pursuing this with the various approaches you have tried.
::: mail/components/nsIMailGlue.idl
@@ +17,5 @@
> *
> */
> void sanitize(in nsIDOMWindow aParentWindow);
>
> + void finalUiStartupDone(out boolean aDone);
Can this be made 'attribute boolean finalUiStartupDone' ?
::: mailnews/base/util/nsMsgDBFolder.cpp
@@ +2727,2 @@
> nsresult rv;
> + if (!aForce) {
Can you add some TODO comment that all these hacks can go if m-c changes
the localization infrastructure so that the localized strings are
available immediately?
@@ +3182,5 @@
> (name.LowerCaseEqualsLiteral("outbox") && nonEnglishApp());
> }
>
> NS_IMETHODIMP nsMsgDBFolder::SetPrettyName(const nsAString &name) {
> + initializeStrings();
Could we actually check the return value of initializeStrings? It can
fail at many sports and reports the errors, but we never check it at the
callers.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1847772
Title:
E-mail folder names are not localized in thunderbird 68
To manage notifications about this bug go to:
https://bugs.launchpad.net/thunderbird/+bug/1847772/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
